Replace internal pybids calls with installed pybids calls #213
Conversation
tsalo
added
the
maintenance
Codecov ReportBase: 39.95% // Head: 44.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 39.95% 44.18% +4.22%
==========================================
Files 192 145 -47
Lines 19940 13440 -6500
==========================================
- Hits 7967 5938 -2029
+ Misses 11973 7502 -4471
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aslprep/niworkflows/viz/utils.py
Outdated
| @@ -403,8 +403,8 @@ def _compose_view(bg_svgs, fg_svgs, ref=0): | |||
| else: | |||
| newroots = roots | |||
| fig.append(newroots) | |||
| fig.root.attrib.pop("width") | |||
| fig.root.attrib.pop("height") | |||
| fig.root.attrib.pop("width", None) | |||
There was a problem hiding this comment.
does pop not automatically return None?
There was a problem hiding this comment.
It started breaking when I unpinned the svgutils version. I haven't checked what the attrib attribute is, so it might not be a regular dictionary. I copied the fix from the current version of niworkflows.
tsalo
changed the title
Closes None, but works toward #199.
Changes proposed in this pull request
aslprep.pybidswithbids(the installed dependency).